netdev - Re: [PATCH net-next v2] netfilter: Fix incorrect tc_setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200326.200409.835123184765124238.davem@davemloft.net>
Date:   Thu, 26 Mar 2020 20:04:09 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     wenxu@...oud.cn
Cc:     netdev@...r.kernel.org, netfilter-devel@...r.kernel.org
Subject: Re: [PATCH net-next v2] netfilter: Fix incorrect tc_setup_type
 type for flowtable offload

From: wenxu@...oud.cn
Date: Tue, 24 Mar 2020 07:34:25 +0800

> From: wenxu <wenxu@...oud.cn>
> 
> Flowtable offload setup flow_offlod_block in TC_SETP_FT. The indr block
> offload of flowtable also should setup in TC_SETUP_FT.
> But flow_indr_block_call always sets the tc_set_up_type as TC_SETUP_BLOCK.
> So function flow_indr_block_call should expose a parameters to set
> the tc_setup_type for each offload subsystem.
> 
> Fixes: b5140a36da78 ("netfilter: flowtable: add indr block setup support")
> Signed-off-by: wenxu <wenxu@...oud.cn>
> ---
> v2: modify the comments

Do the netfilter folks want to take this or should I apply it directly?

Thanks.