netdev - Re: [PATCH net] r8169: fix PHY driver check on platforms w/o module softdeps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d2a7f1f1-cf74-ab63-3361-6adc0576aa89@gmail.com>
Date:   Sat, 28 Mar 2020 00:10:57 +0100
From:   Heiner Kallweit <hkallweit1@...il.com>
To:     David Miller <davem@...emloft.net>
Cc:     nic_swsd@...ltek.com, cwhuang@...roid-x86.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH net] r8169: fix PHY driver check on platforms w/o module
 softdeps

On 27.03.2020 23:57, David Miller wrote:
> From: Heiner Kallweit <hkallweit1@...il.com>
> Date: Fri, 27 Mar 2020 17:33:32 +0100
> 
>> On Android/x86 the module loading infrastructure can't deal with
>> softdeps. Therefore the check for presence of the Realtek PHY driver
>> module fails. mdiobus_register() will try to load the PHY driver
>> module, therefore move the check to after this call and explicitly
>> check that a dedicated PHY driver is bound to the PHY device.
>>
>> Fixes: f32593773549 ("r8169: check that Realtek PHY driver module is loaded")
>> Reported-by: Chih-Wei Huang <cwhuang@...roid-x86.org>
>> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>
>> ---
>> Please apply fix back to 5.4 only. On 4.19 it would break processing.
> 
> Applied, but am I missing something here?  The Fixes: tag is a v5.6 change
> which was not sent to -stable.
> 
Somehow that change made it to -stable. See e.g. commit
85a19b0e31e256e77fd4124804b9cec10619de5e for 4.19.