netdev - Re: [PATCH net-next v2 2/3] net: phylink: rename 'ops' to 'mac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cacfd159-4881-5c35-0e63-decac322a9c7@gmail.com>
Date:   Sun, 29 Mar 2020 13:33:47 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Russell King <rmk+kernel@...linux.org.uk>,
        Andrew Lunn <andrew@...n.ch>,
        Heiner Kallweit <hkallweit1@...il.com>
Cc:     "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2 2/3] net: phylink: rename 'ops' to 'mac_ops'



On 3/29/2020 9:01 AM, Russell King wrote:
> Rename the bland 'ops' member of struct phylink to be a more
> descriptive 'mac_ops' - this is necessary as we're about to introduce
> another set of operations.
> 
> Reviewed-by: Andrew Lunn <andrew@...n.ch>
> Signed-off-by: Russell King <rmk+kernel@...linux.org.uk>
> ---

[snip]

> @@ -679,7 +679,7 @@ static int phylink_register_sfp(struct phylink *pl,
>  struct phylink *phylink_create(struct phylink_config *config,
>  			       struct fwnode_handle *fwnode,
>  			       phy_interface_t iface,
> -			       const struct phylink_mac_ops *ops)
> +			       const struct phylink_mac_ops *mac_ops)

This function signature in include/linux/phylink.h needs changing to
reflect the change in the argument, with that:

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian