netdev - Re: [PATCH net-next v2 3/3] net: phylink: add separate pcs operations structure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ab4164b1-2415-ec81-c235-0d3469dba4af@gmail.com>
Date:   Sun, 29 Mar 2020 13:42:08 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Russell King <rmk+kernel@...linux.org.uk>,
        Andrew Lunn <andrew@...n.ch>,
        Heiner Kallweit <hkallweit1@...il.com>
Cc:     "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2 3/3] net: phylink: add separate pcs operations
 structure



On 3/29/2020 9:01 AM, Russell King wrote:
> Add a separate set of PCS operations, which MAC drivers can use to
> couple phylink with their associated MAC PCS layer.  The PCS
> operations include:
> 
> - pcs_get_state() - reads the link up/down, resolved speed, duplex
>    and pause from the PCS.
> - pcs_config() - configures the PCS for the specified mode, PHY
>    interface type, and setting the advertisement.
> - pcs_an_restart() - restarts 802.3 in-band negotiation with the
>    link partner
> - pcs_link_up() - informs the PCS that link has come up, and the
>    parameters of the link. Link parameters are used to program the
>    PCS for fixed speed and non-inband modes.
> 
> Signed-off-by: Russell King <rmk+kernel@...linux.org.uk>
> ---

Although your kernel documentation is pretty comprehensive, I am fairly
sure people are going to get confused about whether they need to
implement pcs_an_restart vs. mac_an_restart and pcs_get_state vs.
mac_pcs_get_state (with the possibility of a naming confusion for the
latter). Maybe some guidelines in the comment as to which one to
implement could save some support.

Other than that:

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian