netdev - Re: 5.6.0-rc7+ fails to connect to wifi network

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2fae533d-8b38-3462-f862-aab60b9bd419@googlemail.com>
Date:   Sun, 29 Mar 2020 21:45:53 +0100
From:   Chris Clayton <chris2553@...glemail.com>
To:     Jouni Malinen <jouni@...eaurora.org>
Cc:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        David Miller <davem@...emloft.net>, johannes.berg@...el.com
Subject: Re: 5.6.0-rc7+ fails to connect to wifi network



On 29/03/2020 20:51, Jouni Malinen wrote:
> 
> Thanks for finding and reporting this. The changes here were indeed
> supposed to apply only to Data frames and that's what they did with the
> driver I tested this with which is why this did not come up earlier.
> However, this path can get Management frames (and it was indeed the
> Authentication frames that were getting dropped in your case with
> iwlwifi) and that needs to addressed in the conditions here.
> 
> Johannes fixed this with the following change:
> https://patchwork.kernel.org/patch/11464207/
> 
  CC [M]  net/mac80211/tx.o
In file included from ./include/linux/export.h:43,
                 from ./include/linux/linkage.h:7,
                 from ./include/linux/kernel.h:8,
                 from net/mac80211/tx.c:13:
net/mac80211/tx.c: In function 'ieee80211_tx_dequeue':
net/mac80211/tx.c:3613:37: error: 'struct ieee80211_hdr' has no member named 'fc'
 3613 |   if (unlikely(ieee80211_is_data(hdr->fc) &&
      |                                     ^~
./include/linux/compiler.h:78:42: note: in definition of macro 'unlikely'
   78 | # define unlikely(x) __builtin_expect(!!(x), 0)
      |                                          ^
make[2]: *** [scripts/Makefile.build:267: net/mac80211/tx.o] Error 1
make[1]: *** [scripts/Makefile.build:505: net/mac80211] Error 2
make: *** [Makefile:1683: net] Error 2
make: *** Waiting for unfinished jobs....