netdev - Re: [PATCH net 1/1] net: fix fraglist segmentation reference count leak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200330165911.GS13121@gauss3.secunet.de>
Date:   Mon, 30 Mar 2020 18:59:11 +0200
From:   Steffen Klassert <steffen.klassert@...unet.com>
To:     Florian Westphal <fw@...len.de>
CC:     <netdev@...r.kernel.org>, Xiumei Mu <xmu@...hat.com>,
        Xin Long <lucien.xin@...il.com>
Subject: Re: [PATCH net 1/1] net: fix fraglist segmentation reference count
 leak

On Mon, Mar 30, 2020 at 06:51:29PM +0200, Florian Westphal wrote:
> Xin Long says:
>  On udp rx path udp_rcv_segment() may do segment where the frag skbs
>  will get the header copied from the head skb in skb_segment_list()
>  by calling __copy_skb_header(), which could overwrite the frag skbs'
>  extensions by __skb_ext_copy() and cause a leak.
> 
>  This issue was found after loading esp_offload where a sec path ext
>  is set in the skb.
> 
> Fix this by discarding head state of the fraglist skb before replacing
> its contents.
> 
> Fixes: 3a1296a38d0cf62 ("net: Support GRO/GSO fraglist chaining.")
> Cc: Steffen Klassert <steffen.klassert@...unet.com>
> Reported-by: Xiumei Mu <xmu@...hat.com>
> Tested-by: Xin Long <lucien.xin@...il.com>
> Signed-off-by: Florian Westphal <fw@...len.de>

Acked-by: Steffen Klassert <steffen.klassert@...unet.com>