netdev - Re: [PATCH net] udp: initialize is_flist with 0 in udp_gro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200330170117.GT13121@gauss3.secunet.de>
Date:   Mon, 30 Mar 2020 19:01:17 +0200
From:   Steffen Klassert <steffen.klassert@...unet.com>
To:     Xin Long <lucien.xin@...il.com>
CC:     network dev <netdev@...r.kernel.org>, <davem@...emloft.net>,
        Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH net] udp: initialize is_flist with 0 in udp_gro_receive

On Mon, Mar 30, 2020 at 11:31:45PM +0800, Xin Long wrote:
> Without NAPI_GRO_CB(skb)->is_flist initialized, when the dev doesn't
> support NETIF_F_GRO_FRAGLIST, is_flist can still be set and fraglist
> will be used in udp_gro_receive().
> 
> So fix it by initializing is_flist with 0 in udp_gro_receive.
> 
> Fixes: 9fd1ff5d2ac7 ("udp: Support UDP fraglist GRO/GSO.")
> Signed-off-by: Xin Long <lucien.xin@...il.com>

Acked-by: Steffen Klassert <steffen.klassert@...unet.com>