netdev - Re: [PATCH v2 net-next 0/8] ionic support for firmware upgrade

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 30 Mar 2020 11:41:04 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     snelson@...sando.io
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH v2 net-next 0/8] ionic support for firmware upgrade

From: Shannon Nelson <snelson@...sando.io>
Date: Fri, 27 Mar 2020 20:14:40 -0700

> The Pensando Distributed Services Card can get firmware upgrades from
> the off-host centralized management suite, and can be upgraded without a
> host reboot or driver reload.  This patchset sets up the support for fw
> upgrade in the Linux driver.
> 
> When the upgrade begins, the DSC first brings the link down, then stops
> the firmware.  The driver will notice this and quiesce itself by stopping
> the queues and releasing DMA resources, then monitoring for firmware to
> start back up.  When the upgrade is finished the firmware is restarted
> and link is brought up, and the driver rebuilds the queues and restarts
> traffic flow.
> 
> First we separate the Link state from the netdev state, then reorganize a
> few things to prepare for partial tear-down of the queues.  Next we fix
> up the state machine so that we take the Tx and Rx queues down and back
> up when we get LINK_DOWN and LINK_UP events.  Lastly, we add handling of
> the FW reset itself by tearing down the lif internals and rebuilding them
> with the new FW setup.
> 
> v2: This changes the design from (ab)using the full .ndo_stop and
>     .ndo_open routines to getting a better separation between the
>     alloc and the init functions so that we can keep our resource
>     allocations as long as possible.

Series applied, thank you.