netdev - Re: [PATCH] net: phy: at803x: fix clock sink configuration on ATH8030 and ATH8035

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200401171747.GW25745@shell.armlinux.org.uk>
Date:   Wed, 1 Apr 2020 18:17:48 +0100
From:   Russell King - ARM Linux admin <linux@...linux.org.uk>
To:     Oleksij Rempel <o.rempel@...gutronix.de>
Cc:     Andrew Lunn <andrew@...n.ch>,
        Florian Fainelli <f.fainelli@...il.com>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Mark Rutland <mark.rutland@....com>,
        Rob Herring <robh+dt@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Shawn Guo <shawnguo@...nel.org>,
        David Jander <david@...tonic.nl>,
        "David S. Miller" <davem@...emloft.net>,
        devicetree@...r.kernel.org, Fabio Estevam <festevam@...il.com>,
        kernel@...gutronix.de, Liam Girdwood <lgirdwood@...il.com>,
        linux-arm-kernel@...ts.infradead.org, linux-imx@....com,
        linux-kernel@...r.kernel.org, Mark Brown <broonie@...nel.org>,
        netdev@...r.kernel.org,
        Philippe Schenker <philippe.schenker@...adex.com>
Subject: Re: [PATCH] net: phy: at803x: fix clock sink configuration on
 ATH8030 and ATH8035

On Wed, Apr 01, 2020 at 11:57:32AM +0200, Oleksij Rempel wrote:
> The masks in priv->clk_25m_reg and priv->clk_25m_mask are one-bits-set
> for the values that comprise the fields, not zero-bits-set.
> 
> This patch fixes the clock frequency configuration for ATH8030 and
> ATH8035 Atheros PHYs by removing the erroneous "~".
> 
> To reproduce this bug, configure the PHY  with the device tree binding
> "qca,clk-out-frequency" and remove the machine specific PHY fixups.
> 
> Fixes: 2f664823a47021 ("net: phy: at803x: add device tree binding")
> Reported-by: Russell King <linux@...linux.org.uk>

Please replace this with:

Reported-by: Russell King <rmk+kernel@...linux.org.uk>

> Signed-off-by: Oleksij Rempel <o.rempel@...gutronix.de>

Reviewed-by: Russell King <rmk+kernel@...linux.org.uk>
Tested-by: Russell King <rmk+kernel@...linux.org.uk>

Thanks.

> ---
>  drivers/net/phy/at803x.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c
> index 481cf48c9b9e4..31f731e6df720 100644
> --- a/drivers/net/phy/at803x.c
> +++ b/drivers/net/phy/at803x.c
> @@ -425,8 +425,8 @@ static int at803x_parse_dt(struct phy_device *phydev)
>  		 */
>  		if (at803x_match_phy_id(phydev, ATH8030_PHY_ID) ||
>  		    at803x_match_phy_id(phydev, ATH8035_PHY_ID)) {
> -			priv->clk_25m_reg &= ~AT8035_CLK_OUT_MASK;
> -			priv->clk_25m_mask &= ~AT8035_CLK_OUT_MASK;
> +			priv->clk_25m_reg &= AT8035_CLK_OUT_MASK;
> +			priv->clk_25m_mask &= AT8035_CLK_OUT_MASK;
>  		}
>  	}
>  
> -- 
> 2.26.0.rc2
> 
> 

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 10.2Mbps down 587kbps up