netdev - Re: [PATCH] net: phy: at803x: fix clock sink configuration on ATH8030 and ATH8035

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200401.112136.685481342101422062.davem@davemloft.net>
Date:   Wed, 01 Apr 2020 11:21:36 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     o.rempel@...gutronix.de
Cc:     andrew@...n.ch, f.fainelli@...il.com, hkallweit1@...il.com,
        mark.rutland@....com, robh+dt@...nel.org, s.hauer@...gutronix.de,
        shawnguo@...nel.org, linux@...linux.org.uk, david@...tonic.nl,
        devicetree@...r.kernel.org, festevam@...il.com,
        kernel@...gutronix.de, lgirdwood@...il.com,
        linux-arm-kernel@...ts.infradead.org, linux-imx@....com,
        linux-kernel@...r.kernel.org, broonie@...nel.org,
        netdev@...r.kernel.org, philippe.schenker@...adex.com
Subject: Re: [PATCH] net: phy: at803x: fix clock sink configuration on
 ATH8030 and ATH8035

From: Oleksij Rempel <o.rempel@...gutronix.de>
Date: Wed,  1 Apr 2020 11:57:32 +0200

> The masks in priv->clk_25m_reg and priv->clk_25m_mask are one-bits-set
> for the values that comprise the fields, not zero-bits-set.
> 
> This patch fixes the clock frequency configuration for ATH8030 and
> ATH8035 Atheros PHYs by removing the erroneous "~".
> 
> To reproduce this bug, configure the PHY  with the device tree binding
> "qca,clk-out-frequency" and remove the machine specific PHY fixups.
> 
> Fixes: 2f664823a47021 ("net: phy: at803x: add device tree binding")
> Reported-by: Russell King <linux@...linux.org.uk>
> Signed-off-by: Oleksij Rempel <o.rempel@...gutronix.de>

Applied with Reported-by: fixed and queued up for -stable, thanks.