netdev - Re: [PATCH v2] slcan: Don't transmit uninitialized stack data in padding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200401.112318.291287510384908654.davem@davemloft.net>
Date:   Wed, 01 Apr 2020 11:23:18 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     rpalethorpe@...e.com
Cc:     linux-can@...r.kernel.org, keescook@...omium.org,
        netdev@...r.kernel.org, security@...nel.org, wg@...ndegger.com,
        mkl@...gutronix.de
Subject: Re: [PATCH v2] slcan: Don't transmit uninitialized stack data in
 padding

From: Richard Palethorpe <rpalethorpe@...e.com>
Date: Wed,  1 Apr 2020 12:06:39 +0200

> struct can_frame contains some padding which is not explicitly zeroed in
> slc_bump. This uninitialized data will then be transmitted if the stack
> initialization hardening feature is not enabled (CONFIG_INIT_STACK_ALL).
> 
> This commit just zeroes the whole struct including the padding.
> 
> Signed-off-by: Richard Palethorpe <rpalethorpe@...e.com>
> Fixes: a1044e36e457 ("can: add slcan driver for serial/USB-serial CAN adapters")
> Reviewed-by: Kees Cook <keescook@...omium.org>

Applied and queued up for -stable, thanks.