netdev - Re: [PATCH net] net: cavium: Fix build errors due to 'imply CAVIUM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200402.070145.1146009613887902250.davem@davemloft.net>
Date:   Thu, 02 Apr 2020 07:01:45 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     yuehaibing@...wei.com
Cc:     nishadkamdar@...il.com, nico@...xnic.net, masahiroy@...nel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        gakula@...vell.com
Subject: Re: [PATCH net] net: cavium: Fix build errors due to 'imply
 CAVIUM_PTP'

From: YueHaibing <yuehaibing@...wei.com>
Date: Thu, 2 Apr 2020 21:23:44 +0800

> If CAVIUM_PTP is m and THUNDER_NIC_VF is y, build fails:
> 
> drivers/net/ethernet/cavium/thunder/nicvf_main.o: In function 'nicvf_remove':
> nicvf_main.c:(.text+0x1f0): undefined reference to 'cavium_ptp_put'
> drivers/net/ethernet/cavium/thunder/nicvf_main.o: In function `nicvf_probe':
> nicvf_main.c:(.text+0x557c): undefined reference to 'cavium_ptp_get'
> 
> THUNDER_NIC_VF imply CAVIUM_PTP, which allow the config now,
> Use IS_REACHABLE() to avoid the vmlinux link error for this case.
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Fixes: def2fbffe62c ("kconfig: allow symbols implied by y to become m")
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>

Applied, thanks.