netdev - Re: [PATCH] net: stmmac: dwmac1000: fix out-of-bounds mac address reg setting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200403.155930.1942213327887906330.davem@davemloft.net>
Date:   Fri, 03 Apr 2020 15:59:30 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     jszhang3@...l.ustc.edu.cn
Cc:     peppe.cavallaro@...com, alexandre.torgue@...com,
        joabreu@...opsys.com, netdev@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: stmmac: dwmac1000: fix out-of-bounds mac address
 reg setting

From: Jisheng Zhang <jszhang3@...l.ustc.edu.cn>
Date: Fri, 3 Apr 2020 10:23:29 +0800

> From: Jisheng Zhang <Jisheng.Zhang@...aptics.com>
> 
> Commit 9463c4455900 ("net: stmmac: dwmac1000: Clear unused address
> entries") cleared the unused mac address entries, but introduced an
> out-of bounds mac address register programming bug -- After setting
> the secondary unicast mac addresses, the "reg" value has reached
> netdev_uc_count() + 1, thus we should only clear address entries
> if (addr < perfect_addr_number)
> 
> Fixes: 9463c4455900 ("net: stmmac: dwmac1000: Clear unused address entries")
> Signed-off-by: Jisheng Zhang <Jisheng.Zhang@...aptics.com>

Applied and queued up for -stable, thanks.