netdev - Re: [Patch net] net_sched: fix a missing refcnt in tcindex

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 03 Apr 2020 16:01:08 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     xiyou.wangcong@...il.com
Cc:     netdev@...r.kernel.org,
        syzbot+8325e509a1bf83ec741d@...kaller.appspotmail.com,
        jhs@...atatu.com, jiri@...nulli.us, paulmck@...nel.org
Subject: Re: [Patch net] net_sched: fix a missing refcnt in tcindex_init()

From: Cong Wang <xiyou.wangcong@...il.com>
Date: Thu,  2 Apr 2020 20:58:51 -0700

> The initial refcnt of struct tcindex_data should be 1,
> it is clear that I forgot to set it to 1 in tcindex_init().
> This leads to a dec-after-zero warning.
> 
> Reported-by: syzbot+8325e509a1bf83ec741d@...kaller.appspotmail.com
> Fixes: 304e024216a8 ("net_sched: add a temporary refcnt for struct tcindex_data")
> Cc: Jamal Hadi Salim <jhs@...atatu.com>
> Cc: Jiri Pirko <jiri@...nulli.us>
> Cc: Paul E. McKenney <paulmck@...nel.org>
> Signed-off-by: Cong Wang <xiyou.wangcong@...il.com>

Applied, thanks Cong.