netdev - Re: [PATCH] xsk: fix out of boundary write in __xsk_rcv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7dbc67e0-aaca-9809-3cda-34f3d5791337@iogearbox.net>
Date:   Mon, 6 Apr 2020 22:12:57 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Björn Töpel <bjorn.topel@...il.com>,
        Jonathan Lemon <jonathan.lemon@...il.com>
Cc:     Li RongQing <lirongqing@...du.com>,
        Netdev <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>,
        Kevin Laatz <kevin.laatz@...el.com>,
        Ciara Loftus <ciara.loftus@...el.com>,
        Bruce Richardson <bruce.richardson@...el.com>,
        magnus.karlsson@...el.com
Subject: Re: [PATCH] xsk: fix out of boundary write in __xsk_rcv_memcpy

On 4/3/20 10:29 AM, Björn Töpel wrote:
> On Fri, 3 Apr 2020 at 00:22, Jonathan Lemon <jonathan.lemon@...il.com> wrote:
>> On 2 Apr 2020, at 0:52, Li RongQing wrote:
>>
>>> first_len is remainder of first page, if write size is
>>> larger than it, out of page boundary write will happen
>>>
>>> Fixes: c05cd3645814 "(xsk: add support to allow unaligned chunk placement)"
>>> Signed-off-by: Li RongQing <lirongqing@...du.com>
>>
>> Acked-by: Jonathan Lemon <jonathan.lemon@...il.com>
> 
> Good catch!
> Acked-by: Björn Töpel <bjorn.topel@...el.com>

Applied, thanks!

Björn, Magnus, others, would be really valuable to have a proper kselftest suite
in BPF for covering everything xsk related, including such corner cases as Li fixed
here, wdyt? ;-)

Thanks,
Daniel