netdev - Re: [PATCH] xsk: fix out of boundary write in __xsk_rcv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJ+HfNhYqPuX6zC3QZi=aQ0=j_z2gNPBmkYohm-hkP7q4pE_ug@mail.gmail.com>
Date:   Tue, 7 Apr 2020 06:35:39 +0200
From:   Björn Töpel <bjorn.topel@...il.com>
To:     Daniel Borkmann <daniel@...earbox.net>
Cc:     Jonathan Lemon <jonathan.lemon@...il.com>,
        Li RongQing <lirongqing@...du.com>,
        Netdev <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>,
        Kevin Laatz <kevin.laatz@...el.com>,
        Ciara Loftus <ciara.loftus@...el.com>,
        Bruce Richardson <bruce.richardson@...el.com>,
        "Karlsson, Magnus" <magnus.karlsson@...el.com>
Subject: Re: [PATCH] xsk: fix out of boundary write in __xsk_rcv_memcpy

On Mon, 6 Apr 2020 at 22:13, Daniel Borkmann <daniel@...earbox.net> wrote:
>
> On 4/3/20 10:29 AM, Björn Töpel wrote:
> > On Fri, 3 Apr 2020 at 00:22, Jonathan Lemon <jonathan.lemon@...il.com> wrote:
> >> On 2 Apr 2020, at 0:52, Li RongQing wrote:
> >>
> >>> first_len is remainder of first page, if write size is
> >>> larger than it, out of page boundary write will happen
> >>>
> >>> Fixes: c05cd3645814 "(xsk: add support to allow unaligned chunk placement)"
> >>> Signed-off-by: Li RongQing <lirongqing@...du.com>
> >>
> >> Acked-by: Jonathan Lemon <jonathan.lemon@...il.com>
> >
> > Good catch!
> > Acked-by: Björn Töpel <bjorn.topel@...el.com>
>
> Applied, thanks!
>
> Björn, Magnus, others, would be really valuable to have a proper kselftest suite
> in BPF for covering everything xsk related, including such corner cases as Li fixed
> here, wdyt? ;-)
>

Indeed. It's *very much* overdue. :-(


Björn

> Thanks,
> Daniel