netdev - Re: [PATCH bpf] bpf: Fix use of sk->sk_reuseport from sk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200408181243.abadjuapq7z7tzpr@kafai-mbp>
Date:   Wed, 8 Apr 2020 11:12:43 -0700
From:   Martin KaFai Lau <kafai@...com>
To:     unlisted-recipients:; (no To-header on input)
CC:     <bpf@...r.kernel.org>, <netdev@...r.kernel.org>,
        <daniel@...earbox.net>, <ast@...nel.org>
Subject: Re: [PATCH bpf] bpf: Fix use of sk->sk_reuseport from sk_assign

On Tue, Apr 07, 2020 at 08:35:40PM -0700, Joe Stringer wrote:
> In testing, we found that for request sockets the sk->sk_reuseport field
> may yet be uninitialized, which caused bpf_sk_assign() to randomly
> succeed or return -ESOCKTNOSUPPORT when handling the forward ACK in a
> three-way handshake.
> 
> Fix it by only applying the reuseport check for full sockets.
Acked-by: Martin KaFai Lau <kafai@...com>