netdev - Re: [PATCH bpf] bpf: Fix use of sk->sk_reuseport from sk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7be18104-f499-19af-a513-cfc39d2c491b@iogearbox.net>
Date:   Thu, 9 Apr 2020 01:14:01 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Joe Stringer <joe@...d.net.nz>, bpf@...r.kernel.org
Cc:     netdev@...r.kernel.org, ast@...nel.org
Subject: Re: [PATCH bpf] bpf: Fix use of sk->sk_reuseport from sk_assign

On 4/8/20 5:35 AM, Joe Stringer wrote:
> In testing, we found that for request sockets the sk->sk_reuseport field
> may yet be uninitialized, which caused bpf_sk_assign() to randomly
> succeed or return -ESOCKTNOSUPPORT when handling the forward ACK in a
> three-way handshake.
> 
> Fix it by only applying the reuseport check for full sockets.
> 
> Fixes: cf7fbe660f2d ("bpf: Add socket assign support")
> Signed-off-by: Joe Stringer <joe@...d.net.nz>

Applied, thanks!