netdev - Re: [PATCH net] net: macsec: fix using wrong structure in macsec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200409.101704.1725996128523021782.davem@davemloft.net>
Date:   Thu, 09 Apr 2020 10:17:04 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     ap420073@...il.com
Cc:     kuba@...nel.org, netdev@...r.kernel.org, antoine.tenart@...tlin.com
Subject: Re: [PATCH net] net: macsec: fix using wrong structure in
 macsec_changelink()

From: Taehee Yoo <ap420073@...il.com>
Date: Thu,  9 Apr 2020 14:08:08 +0000

> In the macsec_changelink(), "struct macsec_tx_sa tx_sc" is used to
> store "macsec_secy.tx_sc".
> But, the struct type of tx_sc is macsec_tx_sc, not macsec_tx_sa.
> So, the macsec_tx_sc should be used instead.
> 
> Test commands:
>     ip link add dummy0 type dummy
>     ip link add macsec0 link dummy0 type macsec
>     ip link set macsec0 type macsec encrypt off
> 
> Splat looks like:
> [61119.963483][ T9335] ==================================================================
> [61119.964709][ T9335] BUG: KASAN: slab-out-of-bounds in macsec_changelink.part.34+0xb6/0x200 [macsec]
> [61119.965787][ T9335] Read of size 160 at addr ffff888020d69c68 by task ip/9335
 ...
> Fixes: 3cf3227a21d1 ("net: macsec: hardware offloading infrastructure")
> Signed-off-by: Taehee Yoo <ap420073@...il.com>

Applied and queued up for v5.6 -stable, thank you.