netdev - Re: [PATCH] nfp: Fix memory leak in nfp_resource

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200409.101844.1655988786538703860.davem@davemloft.net>
Date:   Thu, 09 Apr 2020 10:18:44 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     keitasuzuki.park@...ab.ics.keio.ac.jp
Cc:     takafumi.kubota1012@...ab.ics.keio.ac.jp, kuba@...nel.org,
        oss-drivers@...ronome.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] nfp: Fix memory leak in nfp_resource_acquire()

From: Keita Suzuki <keitasuzuki.park@...ab.ics.keio.ac.jp>
Date: Thu,  9 Apr 2020 15:02:07 +0000

> This patch fixes a memory leak in nfp_resource_acquire(). res->mutex is
> alllocated in nfp_resource_try_acquire(). However, when
> msleep_interruptible() or time_is_before_eq_jiffies() fails, it falls
> into err_fails path where res is freed, but res->mutex is not.
> 
> Fix this by changing call to free to nfp_resource_release().
> 
> Signed-off-by: Keita Suzuki <keitasuzuki.park@...ab.ics.keio.ac.jp>

Did you test compile this?

drivers/net/ethernet/netronome/nfp/nfpcore/nfp_resource.c: In function ‘nfp_resource_acquire’:
drivers/net/ethernet/netronome/nfp/nfpcore/nfp_resource.c:203:2: error: implicit declaration of function ‘nfp_resource_relase’; did you mean ‘nfp_resource_release’? [-Werror=implicit-function-declaration]
  nfp_resource_relase(res);
  ^~~~~~~~~~~~~~~~~~~
  nfp_resource_release

And this makes me feel like the test was not runtime tested either.