netdev - Re: [PATCH net v1] net/sched: Don't print dump stack in event of transmission timeout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200413112530.GL334007@unreal>
Date:   Mon, 13 Apr 2020 14:25:30 +0300
From:   Leon Romanovsky <leon@...nel.org>
To:     Jose Abreu <Jose.Abreu@...opsys.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Arjan van de Ven <arjan@...ux.intel.com>,
        Cong Wang <xiyou.wangcong@...il.com>,
        Jamal Hadi Salim <jhs@...atatu.com>,
        Jiri Pirko <jiri@...nulli.us>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net v1] net/sched: Don't print dump stack in event of
 transmission timeout

On Mon, Apr 13, 2020 at 11:01:42AM +0000, Jose Abreu wrote:
> From: Leon Romanovsky <leon@...nel.org>
> Date: Apr/13/2020, 11:54:08 (UTC+00:00)
>
> > Sorry, if I misunderstood you, but you are proposing to count traffic, right?
> >
> > If yes, RDMA traffic bypasses the SW stack and not visible to the kernel, hence
> > the BQL will count only ETH portion of that mixed traffic, while RDMA traffic
> > is the one who "blocked" transmission channel (QP in RDMA terminology).
>
> Sorry but you don't mention in your commit message that this is RDMA
> specific so that's why I brought up the topic of BQL. Apologies for the
> misunderstood.

No problem, I'm glad that you asked those questions, hope that my
answers clear the rationale behind change from WARN_ON to be pr_err().

Thanks

>
> ---
> Thanks,
> Jose Miguel Abreu