lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 13 Apr 2020 17:29:58 -0700 (PDT) From: David Rientjes <rientjes@...gle.com> To: Waiman Long <longman@...hat.com> cc: Andrew Morton <akpm@...ux-foundation.org>, David Howells <dhowells@...hat.com>, Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>, James Morris <jmorris@...ei.org>, "Serge E. Hallyn" <serge@...lyn.com>, Linus Torvalds <torvalds@...ux-foundation.org>, Joe Perches <joe@...ches.com>, Matthew Wilcox <willy@...radead.org>, linux-mm@...ck.org, keyrings@...r.kernel.org, linux-kernel@...r.kernel.org, x86@...nel.org, linux-crypto@...r.kernel.org, linux-s390@...r.kernel.org, linux-pm@...r.kernel.org, linux-stm32@...md-mailman.stormreply.com, linux-arm-kernel@...ts.infradead.org, linux-amlogic@...ts.infradead.org, linux-mediatek@...ts.infradead.org, linuxppc-dev@...ts.ozlabs.org, virtualization@...ts.linux-foundation.org, netdev@...r.kernel.org, intel-wired-lan@...ts.osuosl.org, linux-ppp@...r.kernel.org, wireguard@...ts.zx2c4.com, linux-wireless@...r.kernel.org, devel@...verdev.osuosl.org, linux-scsi@...r.kernel.org, target-devel@...r.kernel.org, linux-btrfs@...r.kernel.org, linux-cifs@...r.kernel.org, samba-technical@...ts.samba.org, linux-fscrypt@...r.kernel.org, ecryptfs@...r.kernel.org, kasan-dev@...glegroups.com, linux-bluetooth@...r.kernel.org, linux-wpan@...r.kernel.org, linux-sctp@...r.kernel.org, linux-nfs@...r.kernel.org, tipc-discussion@...ts.sourceforge.net, cocci@...teme.lip6.fr, linux-security-module@...r.kernel.org, linux-integrity@...r.kernel.org Subject: Re: [PATCH 1/2] mm, treewide: Rename kzfree() to kfree_sensitive() On Mon, 13 Apr 2020, Waiman Long wrote: > As said by Linus: > > A symmetric naming is only helpful if it implies symmetries in use. > Otherwise it's actively misleading. > > In "kzalloc()", the z is meaningful and an important part of what the > caller wants. > > In "kzfree()", the z is actively detrimental, because maybe in the > future we really _might_ want to use that "memfill(0xdeadbeef)" or > something. The "zero" part of the interface isn't even _relevant_. > > The main reason that kzfree() exists is to clear sensitive information > that should not be leaked to other future users of the same memory > objects. > > Rename kzfree() to kfree_sensitive() to follow the example of the > recently added kvfree_sensitive() and make the intention of the API > more explicit. In addition, memzero_explicit() is used to clear the > memory to make sure that it won't get optimized away by the compiler. > > The renaming is done by using the command sequence: > > git grep -w --name-only kzfree |\ > xargs sed -i 's/\bkzfree\b/kfree_sensitive/' > > followed by some editing of the kfree_sensitive() kerneldoc and the > use of memzero_explicit() instead of memset(). > > Suggested-by: Joe Perches <joe@...ches.com> > Signed-off-by: Waiman Long <longman@...hat.com> Acked-by: David Rientjes <rientjes@...gle.com>
Powered by blists - more mailing lists