netdev - Re: [PATCH bpf] xsk: add missing check on user supplied headroom size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <61aa8e08-0a39-306b-e77d-f1398596b6e9@iogearbox.net>
Date:   Wed, 15 Apr 2020 14:33:09 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Magnus Karlsson <magnus.karlsson@...el.com>, bjorn.topel@...el.com,
        ast@...nel.org, netdev@...r.kernel.org, jonathan.lemon@...il.com
Cc:     minhquangbui99@...il.com, bpf@...r.kernel.org
Subject: Re: [PATCH bpf] xsk: add missing check on user supplied headroom size

On 4/14/20 9:35 AM, Magnus Karlsson wrote:
> Add a check that the headroom cannot be larger than the available
> space in the chunk. In the current code, a malicious user can set the
> headroom to a value larger than the chunk size minus the fixed XDP
> headroom. That way packets with a length larger than the supported
> size in the umem could get accepted and result in an out-of-bounds
> write.
> 
> Fixes: c0c77d8fb787 ("xsk: add user memory registration support sockopt")
> Reported-by: Bui Quang Minh <minhquangbui99@...il.com>
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=207225
> Signed-off-by: Magnus Karlsson <magnus.karlsson@...el.com>

Applied, thanks everyone!