netdev - Re: [PATCH] tipc: Fix potential tipc_node refcnt leak in tipc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <53bb4a56-0bd2-3964-7cfb-b5745a8ba25c@web.de>
Date:   Wed, 15 Apr 2020 11:34:54 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Xiyu Yang <xiyuyang19@...an.edu.cn>,
        Xin Tan <tanxin.ctf@...il.com>, netdev@...r.kernel.org,
        tipc-discussion@...ts.sourceforge.net
Cc:     linux-kernel@...r.kernel.org,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Jon Maloy <jmaloy@...hat.com>, Kangjie Lu <kjlu@....edu>,
        Ying Xue <ying.xue@...driver.com>,
        Yuan Zhang <yuanxzhang@...an.edu.cn>
Subject: Re: [PATCH] tipc: Fix potential tipc_node refcnt leak in tipc_rcv

> The issue happens in some paths of tipc_rcv(), which forget to decrease
> the refcnt increased by tipc_node_find() and will cause a refcnt leak.

How do you think about to mention the term “reference counting” in
the commit message?

Would you like to add the tag “Fixes” to the change description?

Regards,
Markus