netdev - Re: [PATCH net-next] net/mlx4_en: avoid indirect call in TX completion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <05bc2889c7ee8be8e33dcf635b85c237927317e9.camel@mellanox.com>
Date:   Fri, 17 Apr 2020 22:59:44 +0000
From:   Saeed Mahameed <saeedm@...lanox.com>
To:     "edumazet@...gle.com" <edumazet@...gle.com>
CC:     "eric.dumazet@...il.com" <eric.dumazet@...il.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "willemb@...gle.com" <willemb@...gle.com>,
        Tariq Toukan <tariqt@...lanox.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] net/mlx4_en: avoid indirect call in TX
 completion

On Fri, 2020-04-17 at 05:09 -0700, Eric Dumazet wrote:
> On Thu, Apr 16, 2020 at 8:55 PM Saeed Mahameed <saeedm@...lanox.com>
> wrote:
> > On Wed, 2020-04-15 at 09:46 -0700, Eric Dumazet wrote:
> > > Commit 9ecc2d86171a ("net/mlx4_en: add xdp forwarding and data
> > > write
> > > support")
> > > brought another indirect call in fast path.
> > > 
> > > Use INDIRECT_CALL_2() helper to avoid the cost of the indirect
> > > call
> > > when/if CONFIG_RETPOLINE=y
> > > 
> > > Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> > > Cc: Tariq Toukan <tariqt@...lanox.com>
> > > Cc: Willem de Bruijn <willemb@...gle.com>
> > > ---
> > 
> > Hi Eric, I believe net-next is still closed.
> > 
> > But FWIW,
> > 
> > Reviewed-by: Saeed Mahameed <saeedm@...lanox.com>
> > 
> 
> Well, this can be pushed to net then, since this is a trivial patch
> that helps performance.
> 
> With this COVID-19 thing, we need more capacity from the serving
> fleet
> (Youtube and all..)
> distributed all over the world and using a high number of CX-3 NIC.
> 
> Thanks.
> 

I don't mind, either net or net-next is fine by me, up to Dave, 

although we are missing the Fixes Tag .. 

Fixes: 9ecc2d86171a ("net/mlx4_en: add xdp forwarding and data write
support")