netdev - Re: [PATCH ipsec] esp6: get the right proto for transport mode in esp6_gso

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200420103822.GG13121@gauss3.secunet.de>
Date:   Mon, 20 Apr 2020 12:38:22 +0200
From:   Steffen Klassert <steffen.klassert@...unet.com>
To:     Xin Long <lucien.xin@...il.com>
CC:     <netdev@...r.kernel.org>, Herbert Xu <herbert@...dor.apana.org.au>,
        "David S. Miller" <davem@...emloft.net>,
        Sabrina Dubroca <sd@...asysnail.net>
Subject: Re: [PATCH ipsec] esp6: get the right proto for transport mode in
 esp6_gso_encap

On Fri, Apr 10, 2020 at 05:06:56PM +0800, Xin Long wrote:
> For transport mode, when ipv6 nexthdr is set, the packet format might
> be like:
> 
>     ----------------------------------------------------
>     |        | dest |     |     |      |  ESP    | ESP |
>     | IP6 hdr| opts.| ESP | TCP | Data | Trailer | ICV |
>     ----------------------------------------------------
> 
> What it wants to get for x-proto in esp6_gso_encap() is the proto that
> will be set in ESP nexthdr. So it should skip all ipv6 nexthdrs and
> get the real transport protocol. Othersize, the wrong proto number
> will be set into ESP nexthdr.
> 
> This patch is to skip all ipv6 nexthdrs by calling ipv6_skip_exthdr()
> in esp6_gso_encap().
> 
> Fixes: 7862b4058b9f ("esp: Add gso handlers for esp4 and esp6")
> Signed-off-by: Xin Long <lucien.xin@...il.com>

Applied, thanks!