netdev - Re: [PATCH ipsec] xfrm: remove the xfrm_state_put call becofe going to out

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200420103924.GH13121@gauss3.secunet.de>
Date:   Mon, 20 Apr 2020 12:39:24 +0200
From:   Steffen Klassert <steffen.klassert@...unet.com>
To:     Xin Long <lucien.xin@...il.com>
CC:     <netdev@...r.kernel.org>, Herbert Xu <herbert@...dor.apana.org.au>,
        "David S. Miller" <davem@...emloft.net>,
        Sabrina Dubroca <sd@...asysnail.net>
Subject: Re: [PATCH ipsec] xfrm: remove the xfrm_state_put call becofe going
 to out_reset

On Fri, Apr 10, 2020 at 05:08:24PM +0800, Xin Long wrote:
> This xfrm_state_put call in esp4/6_gro_receive() will cause
> double put for state, as in out_reset path secpath_reset()
> will put all states set in skb sec_path.
> 
> So fix it by simply remove the xfrm_state_put call.
> 
> Fixes: 6ed69184ed9c ("xfrm: Reset secpath in xfrm failure")
> Signed-off-by: Xin Long <lucien.xin@...il.com>

Also applied, thanks a lot Xin!