netdev - Re: [PATCH v2 4/7] net: macb: fix macb_suspend() by removing call to netif_carrier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 21 Apr 2020 10:16:12 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     nicolas.ferre@...rochip.com, linux-arm-kernel@...ts.infradead.org,
        netdev@...r.kernel.org,
        Claudiu Beznea <claudiu.beznea@...rochip.com>,
        harini.katakam@...inx.com
Cc:     linux-kernel@...r.kernel.org,
        "David S. Miller" <davem@...emloft.net>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        sergio.prado@...abworks.com, antoine.tenart@...tlin.com,
        linux@...linux.org.uk, andrew@...n.ch, michal.simek@...inx.com
Subject: Re: [PATCH v2 4/7] net: macb: fix macb_suspend() by removing call to
 netif_carrier_off()



On 4/21/2020 3:41 AM, nicolas.ferre@...rochip.com wrote:
> From: Nicolas Ferre <nicolas.ferre@...rochip.com>
> 
> As we now use the phylink call to phylink_stop() in the non-WoL path,
> there is no need for this call to netif_carrier_off() anymore. It can
> disturb the underlying phylink FSM.
> 
> Fixes: 7897b071ac3b ("net: macb: convert to phylink")
> Cc: Claudiu Beznea <claudiu.beznea@...rochip.com>
> Cc: Harini Katakam <harini.katakam@...inx.com>
> Cc: Antoine Tenart <antoine.tenart@...tlin.com>
> Signed-off-by: Nicolas Ferre <nicolas.ferre@...rochip.com>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian