netdev - Re: [net-next 1/1] gwdpa: gswip: Introduce Gigabit Ethernet Switch (GSWIP) device driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200421191229.GH933345@lunn.ch>
Date:   Tue, 21 Apr 2020 21:12:29 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Cc:     davem@...emloft.net,
        Jack Ping CHNG <jack.ping.chng@...ux.intel.com>,
        netdev@...r.kernel.org, nhorman@...hat.com, sassmann@...hat.com,
        Amireddy Mallikarjuna reddy 
        <mallikarjunax.reddy@...ux.intel.com>
Subject: Re: [net-next 1/1] gwdpa: gswip: Introduce Gigabit Ethernet Switch
 (GSWIP) device driver

On Mon, Apr 20, 2020 at 08:22:02PM -0700, Jeff Kirsher wrote:
> From: Jack Ping CHNG <jack.ping.chng@...ux.intel.com>
> 
> This driver enables the Intel's LGM SoC GSWIP block. GSWIP is a core module
> tailored for L2/L3/L4+ data plane and QoS functions. It allows CPUs and
> other accelerators connected to the SoC datapath to enqueue and dequeue
> packets through DMAs. Most configuration values are stored in tables
> such as Parsing and Classification Engine tables, Buffer Manager tables
> and Pseudo MAC tables.

I don't find any netdev calls in this. No alloc_netdev or
register_netdev. How are you supposed to use this code?

The device tree binding documentation is missing.

There are also a number of inline functions.

Has this code been reviewed by the usual Intel Open Source Technology
people? GregKH kept pushing for this code to go through those people
so that the code gets a good internal review and fixed up before it is
posted yet again.

       Andrew