netdev - Re: [net-next 02/13] igc: Use netdev log helpers in igc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <158750338551.60047.10607495842380954746@pvrobles-mobl1.amr.corp.intel.com>
Date:   Tue, 21 Apr 2020 14:09:45 -0700
From:   Andre Guedes <andre.guedes@...ux.intel.com>
To:     David Miller <davem@...emloft.net>, jeffrey.t.kirsher@...el.com,
        kuba@...nel.org
Cc:     andre.guedes@...el.com, netdev@...r.kernel.org, nhorman@...hat.com,
        sassmann@...hat.com, aaron.f.brown@...el.com
Subject: Re: [net-next 02/13] igc: Use netdev log helpers in igc_main.c

Hi David/Jakub,

Quoting David Miller (2020-04-21 12:26:10)
> From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> Date: Mon, 20 Apr 2020 16:43:02 -0700
> 
> > It also takes this opportunity to improve some messages and remove
> > the '\n' character at the end of messages since it is automatically
> > added to by netdev_* log helpers.
> 
> Where does this happen?  I can't find it.

A while ago, I came across this LWN article [1] that says printk() begins a
new line in the output unless the KERN_CONT flag is used.

This is probably buried deep down in printk() implementation so that's why it
is hard to find. From a quick look, I think the trick is done in
vprintk_store() and log_output() in kernel/printk/printk.c.

Anyways, I can tell you the driver log messages look exactly the same with or
without the ending '\n'.

> I'm tossing this series, you have to explain where this happens
> because I see several developers who can't figure this out at all.

Hope that clarifies and this series is still good to be merged.

Regards,

Andre

[1] https://lwn.net/Articles/732420/