netdev - Re: [net-next 02/13] igc: Use netdev log helpers in igc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200421.153221.2089591404052111123.davem@davemloft.net>
Date:   Tue, 21 Apr 2020 15:32:21 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     andre.guedes@...ux.intel.com
Cc:     jeffrey.t.kirsher@...el.com, kuba@...nel.org,
        andre.guedes@...el.com, netdev@...r.kernel.org, nhorman@...hat.com,
        sassmann@...hat.com, aaron.f.brown@...el.com
Subject: Re: [net-next 02/13] igc: Use netdev log helpers in igc_main.c

From: Andre Guedes <andre.guedes@...ux.intel.com>
Date: Tue, 21 Apr 2020 14:09:45 -0700

> Quoting David Miller (2020-04-21 12:26:10)
>> I'm tossing this series, you have to explain where this happens
>> because I see several developers who can't figure this out at all.
> 
> Hope that clarifies and this series is still good to be merged.

First of all, the commits make it look like specifically like the
netdev printk facilities do the newline thing.

But overall this looks like just busy work, and I've seen commits
that add missing newlines.

I don't think these changes are valuable nor wise.

Please kill these newline removal changes, thank you.