netdev - RE: [RFC PATCH v5 10/16] RDMA/irdma: Add RoCEv2 UD OP support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9DD61F30A802C4429A01CA4200E302A7DCD485A1@fmsmsx124.amr.corp.intel.com>
Date:   Tue, 21 Apr 2020 00:27:03 +0000
From:   "Saleem, Shiraz" <shiraz.saleem@...el.com>
To:     Leon Romanovsky <leon@...nel.org>,
        "Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>
CC:     "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "jgg@...pe.ca" <jgg@...pe.ca>,
        "Ismail, Mustafa" <mustafa.ismail@...el.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        "nhorman@...hat.com" <nhorman@...hat.com>,
        "sassmann@...hat.com" <sassmann@...hat.com>
Subject: RE: [RFC PATCH v5 10/16] RDMA/irdma: Add RoCEv2 UD OP support

> Subject: Re: [RFC PATCH v5 10/16] RDMA/irdma: Add RoCEv2 UD OP support
> 
> On Fri, Apr 17, 2020 at 10:12:45AM -0700, Jeff Kirsher wrote:
> > From: Mustafa Ismail <mustafa.ismail@...el.com>
> >
> > Add the header, data structures and functions to populate the WQE
> > descriptors and issue the Control QP commands that support RoCEv2 UD
> > operations.
> >
> > Signed-off-by: Mustafa Ismail <mustafa.ismail@...el.com>
> > Signed-off-by: Shiraz Saleem <shiraz.saleem@...el.com>
> > ---

[..]

> > +#define IRDMA_UDA_CQPSQ_QHASH_ENTRYTYPE_S 42 #define
> > +IRDMA_UDA_CQPSQ_QHASH_ENTRYTYPE_M \
> > +	((u64)0x7 << IRDMA_UDA_CQPSQ_QHASH_ENTRYTYPE_S)
> 
> GENMASK*() are better suit here instead of shifts.
> 

OK. I think Jason prefers that too. Will look to make that change in the next rev.