netdev - Re: [PATCH v2 net-next 5/5] dpaa2-eth: use bulk enqueue in .ndo_xdp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200422155117.419b694e@carbon>
Date:   Wed, 22 Apr 2020 15:51:17 +0200
From:   Jesper Dangaard Brouer <brouer@...hat.com>
To:     Ioana Ciornei <ioana.ciornei@....com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, brouer@...hat.com
Subject: Re: [PATCH v2 net-next 5/5] dpaa2-eth: use bulk enqueue in
 .ndo_xdp_xmit

On Wed, 22 Apr 2020 15:05:13 +0300
Ioana Ciornei <ioana.ciornei@....com> wrote:

> Take advantage of the bulk enqueue feature in .ndo_xdp_xmit.
> We cannot use the XDP_XMIT_FLUSH since the architecture is not capable
> to store all the frames dequeued in a NAPI cycle so we instead are
> enqueueing all the frames received in a ndo_xdp_xmit call right away.
> 
> After setting up all FDs for the xdp_frames received, enqueue multiple
> frames at a time until all are sent or the maximum number of retries is
> hit.
> 
> Signed-off-by: Ioana Ciornei <ioana.ciornei@....com>
> ---
> Changes in v2:
>  - use a statically allocated array of dpaa2_fd for each fq
>  - use DEV_MAP_BULK_SIZE as the max number of xdp_frames received

Thanks for doing this.

Acked-by: Jesper Dangaard Brouer <brouer@...hat.com>

-- 
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Principal Kernel Engineer at Red Hat
  LinkedIn: http://www.linkedin.com/in/brouer