netdev - Re: [PATCH v2 net-next 4/5] dpaa2-eth: split the .ndo_xdp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200422155417.230f94a6@carbon>
Date:   Wed, 22 Apr 2020 15:54:17 +0200
From:   Jesper Dangaard Brouer <brouer@...hat.com>
To:     Ioana Ciornei <ioana.ciornei@....com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, brouer@...hat.com
Subject: Re: [PATCH v2 net-next 4/5] dpaa2-eth: split the .ndo_xdp_xmit
 callback into two stages

On Wed, 22 Apr 2020 15:05:12 +0300
Ioana Ciornei <ioana.ciornei@....com> wrote:

> Instead of having a function that both creates a frame descriptor from
> an xdp_frame and enqueues it, split this into two stages.
> Add the dpaa2_eth_xdp_create_fd that just transforms an xdp_frame into a
> FD while the actual enqueue callback is called directly from the ndo for
> each frame.
> This is particulary useful in conjunction with bulk enqueue.
> 
> Signed-off-by: Ioana Ciornei <ioana.ciornei@....com>

LGTM - and I very recently had to do a deep dive into this driver code.

Acked-by: Jesper Dangaard Brouer <brouer@...hat.com>

-- 
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Principal Kernel Engineer at Red Hat
  LinkedIn: http://www.linkedin.com/in/brouer