netdev - Re: [PATCH v2 net-next 0/5] dpaa2-eth: add support for xdp bulk enqueue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200422.201149.711841705818992491.davem@davemloft.net>
Date:   Wed, 22 Apr 2020 20:11:49 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     ioana.ciornei@....com
Cc:     netdev@...r.kernel.org, brouer@...hat.com
Subject: Re: [PATCH v2 net-next 0/5] dpaa2-eth: add support for xdp bulk
 enqueue

From: Ioana Ciornei <ioana.ciornei@....com>
Date: Wed, 22 Apr 2020 15:05:08 +0300

> The first patch moves the DEV_MAP_BULK_SIZE macro into the xdp.h header
> file so that drivers can take advantage of it and use it.
> 
> The following 3 patches are there to setup the scene for using the bulk
> enqueue feature.  First of all, the prototype of the enqueue function is
> changed so that it returns the number of enqueued frames. Second, the
> bulk enqueue interface is used but without any functional changes, still
> one frame at a time is enqueued.  Third, the .ndo_xdp_xmit callback is
> split into two stages, create all FDs for the xdp_frames received and
> then enqueue them.
> 
> The last patch of the series builds on top of the others and instead of
> issuing an enqueue operation for each FD it issues a bulk enqueue call
> for as many frames as possible. This is repeated until all frames are
> enqueued or the maximum number of retries is hit. We do not use the
> XDP_XMIT_FLUSH flag since the architecture is not capable to store all
> frames dequeued in a NAPI cycle, instead we send out right away all
> frames received in a .ndo_xdp_xmit call.
> 
> Changes in v2:
>  - statically allocate an array of dpaa2_fd by frame queue
>  - use the DEV_MAP_BULK_SIZE as the maximum number of xdp_frames
>    received in .ndo_xdp_xmit()

Series applied, thanks.