[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <940d3add-4d12-56ed-617a-8b3bf8ef3a0f@infradead.org>
Date: Wed, 22 Apr 2020 15:37:46 -0700
From: Randy Dunlap <rdunlap@...radead.org>
To: Nicolas Pitre <nico@...xnic.net>,
Jani Nikula <jani.nikula@...ux.intel.com>
Cc: Saeed Mahameed <saeedm@...lanox.com>,
"masahiroy@...nel.org" <masahiroy@...nel.org>,
"Laurent.pinchart@...asonboard.com"
<Laurent.pinchart@...asonboard.com>,
"airlied@...ux.ie" <airlied@...ux.ie>,
"jgg@...pe.ca" <jgg@...pe.ca>,
"linux-kbuild@...r.kernel.org" <linux-kbuild@...r.kernel.org>,
"linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"jernej.skrabec@...l.net" <jernej.skrabec@...l.net>,
"arnd@...db.de" <arnd@...db.de>,
"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
"jonas@...boo.se" <jonas@...boo.se>,
"kieran.bingham+renesas@...asonboard.com"
<kieran.bingham+renesas@...asonboard.com>,
"narmstrong@...libre.com" <narmstrong@...libre.com>,
"leon@...nel.org" <leon@...nel.org>
Subject: Re: [RFC PATCH 1/2] Kconfig: Introduce "uses" keyword
On 4/22/20 2:13 PM, Nicolas Pitre wrote:
> On Wed, 22 Apr 2020, Jani Nikula wrote:
>
>> On Tue, 21 Apr 2020, Nicolas Pitre <nico@...xnic.net> wrote:
>>> This is really a conditional dependency. That's all this is about.
>>> So why not simply making it so rather than fooling ourselves? All that
>>> is required is an extension that would allow:
>>>
>>> depends on (expression) if (expression)
>>>
>>> This construct should be obvious even without reading the doc, is
>>> already used extensively for other things already, and is flexible
>>> enough to cover all sort of cases in addition to this particular one.
>>
>> Okay, you convinced me. Now you only need to convince whoever is doing
>> the actual work of implementing this stuff. ;)
>
> What about this:
>
> ----- >8
> Subject: [PATCH] kconfig: allow for conditional dependencies
>
> This might appear to be a strange concept, but sometimes we want
> a dependency to be conditionally applied. One such case is currently
> expressed with:
>
> depends on FOO || !FOO
>
> This pattern is strange enough to give one's pause. Given that it is
> also frequent, let's make the intent more obvious with some syntaxic
> sugar by effectively making dependencies optionally conditional.
> This also makes the kconfig language more uniform.
>
> Signed-off-by: Nicolas Pitre <nico@...xnic.net>
Hi,
If we must do something here, I prefer this one.
Nicolas, would you do another example, specifically for
CRAMFS_MTD in fs/cramfs/Kconfig, please?
thanks.
--
~Randy
Powered by blists - more mailing lists