netdev - Re: [PATCH net-next 1/3] net: mscc: ocelot: support matching on EtherType

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+h21hpDkc02Hd5JFbD_r3sAtFAOBStQN2dAT+n0aq5SxgKwvw@mail.gmail.com>
Date:   Thu, 23 Apr 2020 01:50:41 +0300
From:   Vladimir Oltean <olteanv@...il.com>
To:     kbuild test robot <lkp@...el.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>, kbuild-all@...ts.01.org,
        Ido Schimmel <idosch@...sch.org>,
        "Allan W. Nielsen" <allan.nielsen@...rochip.com>,
        Horatiu Vultur <horatiu.vultur@...rochip.com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Antoine Tenart <antoine.tenart@...tlin.com>,
        Andrew Lunn <andrew@...n.ch>,
        Florian Fainelli <f.fainelli@...il.com>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Joergen Andreasen <joergen.andreasen@...rochip.com>
Subject: Re: [PATCH net-next 1/3] net: mscc: ocelot: support matching on EtherType

On Thu, 23 Apr 2020 at 01:36, kbuild test robot <lkp@...el.com> wrote:
>
> Hi Vladimir,
>

[...]

>
> sparse warnings: (new ones prefixed by >>)
>
> >> drivers/net/ethernet/mscc/ocelot_flower.c:184:54: sparse: sparse: incorrect type in assignment (different base types) @@    expected unsigned short [usertype] @@    got resunsigned short [usertype] @@

What's a resunsigned short?

> >> drivers/net/ethernet/mscc/ocelot_flower.c:184:54: sparse:    expected unsigned short [usertype]
> >> drivers/net/ethernet/mscc/ocelot_flower.c:184:54: sparse:    got restricted __be16 [usertype]
>

[...]

>    179          if (match_protocol && proto != ETH_P_ALL) {
>    180                  /* TODO: support SNAP, LLC etc */
>    181                  if (proto < ETH_P_802_3_MIN)
>    182                          return -EOPNOTSUPP;
>    183                  ace->type = OCELOT_ACE_TYPE_ETYPE;
>  > 184                  *(u16 *)ace->frame.etype.etype.value = htons(proto);

What's wrong with this? Doesn't it like the left hand side or the
right hand side?

>    185                  *(u16 *)ace->frame.etype.etype.mask = 0xffff;
>    186          }

>
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

-Vladimir