netdev - Re: [PATCH 2/2] rtw88: Use udelay instead of usleep in atomic context

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87d07yn0sw.fsf@kamboji.qca.qualcomm.com>
Date:   Thu, 23 Apr 2020 10:01:03 +0300
From:   Kalle Valo <kvalo@...eaurora.org>
To:     Kai-Heng Feng <kai.heng.feng@...onical.com>
Cc:     Tony Chuang <yhchuang@...ltek.com>,
        "David S. Miller" <davem@...emloft.net>,
        "open list\:REALTEK WIRELESS DRIVER \(rtw88\)" 
        <linux-wireless@...r.kernel.org>,
        "open list\:NETWORKING DRIVERS" <netdev@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] rtw88: Use udelay instead of usleep in atomic context

Kai-Heng Feng <kai.heng.feng@...onical.com> writes:

>> On Apr 23, 2020, at 14:49, Kalle Valo <kvalo@...eaurora.org> wrote:
>> 
>> Kai-Heng Feng <kai.heng.feng@...onical.com> writes:
>> 
>>> It's incorrect to use usleep in atomic context.
>>> 
>>> Switch to a macro which uses udelay instead of usleep to prevent the issue.
>>> 
>>> Signed-off-by: Kai-Heng Feng <kai.heng.feng@...onical.com>
>> 
>> This fixes a regression, right? So there should be a Fixes line.
>
> Yes, but the regression commit isn't in Linus' tree, so the sha1 may change.

No, the commit id won't change after I have commited the patch. I don't
rebase my trees.

-- 
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches