netdev - Re: [PATCH ipsec] ip_vti: receive ipip packet by calling ip_tunnel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 23 Apr 2020 08:07:35 +0200
From:   Steffen Klassert <steffen.klassert@...unet.com>
To:     Xin Long <lucien.xin@...il.com>
CC:     <netdev@...r.kernel.org>, Su Yanjun <suyj.fnst@...fujitsu.com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        "David S. Miller" <davem@...emloft.net>,
        Sabrina Dubroca <sd@...asysnail.net>
Subject: Re: [PATCH ipsec] ip_vti: receive ipip packet by calling
 ip_tunnel_rcv

On Tue, Apr 21, 2020 at 08:46:11PM +0800, Xin Long wrote:
> In Commit dd9ee3444014 ("vti4: Fix a ipip packet processing bug in
> 'IPCOMP' virtual tunnel"), it tries to receive IPIP packets in vti
> by calling xfrm_input(). This case happens when a small packet or
> frag sent by peer is too small to get compressed.
> 
> However, xfrm_input() will still get to the IPCOMP path where skb
> sec_path is set, but never dropped while it should have been done
> in vti_ipcomp4_protocol.cb_handler(vti_rcv_cb), as it's not an
> ipcomp4 packet. This will cause that the packet can never pass
> xfrm4_policy_check() in the upper protocol rcv functions.
> 
> So this patch is to call ip_tunnel_rcv() to process IPIP packets
> instead.
> 
> Fixes: dd9ee3444014 ("vti4: Fix a ipip packet processing bug in 'IPCOMP' virtual tunnel")
> Reported-by: Xiumei Mu <xmu@...hat.com>
> Signed-off-by: Xin Long <lucien.xin@...il.com>

Applied, thanks!