netdev - Re: [PATCH v4 bpf-next 2/3] libbpf: add support for command BPF_ENABLE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAEf4Bzb-8cv9xXQe5qCrTxuxdjvsvyZQJY=GB7vpX7nfKL73PA@mail.gmail.com>
Date:   Fri, 24 Apr 2020 11:09:23 -0700
From:   Andrii Nakryiko <andrii.nakryiko@...il.com>
To:     Song Liu <songliubraving@...com>
Cc:     bpf <bpf@...r.kernel.org>, Networking <netdev@...r.kernel.org>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Kernel Team <kernel-team@...com>
Subject: Re: [PATCH v4 bpf-next 2/3] libbpf: add support for command BPF_ENABLE_STATS

On Thu, Apr 23, 2020 at 11:19 PM Song Liu <songliubraving@...com> wrote:
>
> bpf_enable_stats() is added to enable given stats.
>
> Signed-off-by: Song Liu <songliubraving@...com>
> ---
>  tools/lib/bpf/bpf.c      | 9 +++++++++
>  tools/lib/bpf/bpf.h      | 1 +
>  tools/lib/bpf/libbpf.map | 5 +++++
>  3 files changed, 15 insertions(+)
>
> diff --git a/tools/lib/bpf/bpf.c b/tools/lib/bpf/bpf.c
> index 5cc1b0785d18..c06c25293ab7 100644
> --- a/tools/lib/bpf/bpf.c
> +++ b/tools/lib/bpf/bpf.c
> @@ -826,3 +826,12 @@ int bpf_task_fd_query(int pid, int fd, __u32 flags, char *buf, __u32 *buf_len,
>
>         return err;
>  }
> +
> +int bpf_enable_stats(enum bpf_stats_type type)
> +{
> +       union bpf_attr attr = {};

this has to be memset(0) explicitly due to possibility of compiler not
zero-initializing padding

> +
> +       attr.enable_stats.type = type;
> +
> +       return sys_bpf(BPF_ENABLE_STATS, &attr, sizeof(attr));
> +}
> diff --git a/tools/lib/bpf/bpf.h b/tools/lib/bpf/bpf.h
> index 46d47afdd887..5996e64d324c 100644
> --- a/tools/lib/bpf/bpf.h
> +++ b/tools/lib/bpf/bpf.h
> @@ -229,6 +229,7 @@ LIBBPF_API int bpf_load_btf(void *btf, __u32 btf_size, char *log_buf,
>  LIBBPF_API int bpf_task_fd_query(int pid, int fd, __u32 flags, char *buf,
>                                  __u32 *buf_len, __u32 *prog_id, __u32 *fd_type,
>                                  __u64 *probe_offset, __u64 *probe_addr);
> +LIBBPF_API int bpf_enable_stats(enum bpf_stats_type type);
>
>  #ifdef __cplusplus
>  } /* extern "C" */
> diff --git a/tools/lib/bpf/libbpf.map b/tools/lib/bpf/libbpf.map
> index bb8831605b25..ebd946faada5 100644
> --- a/tools/lib/bpf/libbpf.map
> +++ b/tools/lib/bpf/libbpf.map
> @@ -254,3 +254,8 @@ LIBBPF_0.0.8 {
>                 bpf_program__set_lsm;
>                 bpf_set_link_xdp_fd_opts;
>  } LIBBPF_0.0.7;
> +
> +LIBBPF_0.0.9 {
> +       global:
> +               bpf_enable_stats;
> +} LIBBPF_0.0.8;
> \ No newline at end of file
> --
> 2.24.1
>