netdev - Re: [PATCH net] mptcp: fix race in msk status update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.OSX.2.22.394.2004241123300.64783@zzhu12-mobl.amr.corp.intel.com>
Date:   Fri, 24 Apr 2020 11:24:33 -0700 (PDT)
From:   Mat Martineau <mathew.j.martineau@...ux.intel.com>
To:     Paolo Abeni <pabeni@...hat.com>
cc:     netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
        Davide Caratti <dcaratti@...hat.com>, mptcp@...ts.01.org
Subject: Re: [PATCH net] mptcp: fix race in msk status update


On Fri, 24 Apr 2020, Paolo Abeni wrote:

> Currently subflow_finish_connect() changes unconditionally
> any msk socket status other than TCP_ESTABLISHED.
>
> If an unblocking connect() races with close(), we can end-up
> triggering:
>
> IPv4: Attempt to release TCP socket in state 1 00000000e32b8b7e
>
> when the msk socket is disposed.
>
> Be sure to enter the established status only from SYN_SENT.
>
> Fixes: c3c123d16c0e ("net: mptcp: don't hang in mptcp_sendmsg() after TCP fallback")
> Signed-off-by: Paolo Abeni <pabeni@...hat.com>
> ---

Thanks Paolo, looks good.

Reviewed-by: Mat Martineau <mathew.j.martineau@...ux.intel.com>

--
Mat Martineau
Intel