netdev - Re: [PATCH net] mptcp: fix race in msk status update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200425.204014.4915249663374846.davem@davemloft.net>
Date:   Sat, 25 Apr 2020 20:40:14 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     pabeni@...hat.com
Cc:     netdev@...r.kernel.org, mathew.j.martineau@...ux.intel.com,
        dcaratti@...hat.com, mptcp@...ts.01.org
Subject: Re: [PATCH net] mptcp: fix race in msk status update

From: Paolo Abeni <pabeni@...hat.com>
Date: Fri, 24 Apr 2020 13:15:21 +0200

> Currently subflow_finish_connect() changes unconditionally
> any msk socket status other than TCP_ESTABLISHED.
> 
> If an unblocking connect() races with close(), we can end-up
> triggering:
> 
> IPv4: Attempt to release TCP socket in state 1 00000000e32b8b7e
> 
> when the msk socket is disposed.
> 
> Be sure to enter the established status only from SYN_SENT.
> 
> Fixes: c3c123d16c0e ("net: mptcp: don't hang in mptcp_sendmsg() after TCP fallback")
> Signed-off-by: Paolo Abeni <pabeni@...hat.com>

Applied, thanks.