netdev - Re: [RFC PATCH dpss_eth] Don't initialise ports with no PHY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b6d84c65-a75a-a64d-463f-b0646862e322@gmail.com>
Date:   Fri, 24 Apr 2020 15:50:47 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Darren Stevens <darren@...vens-zone.net>, madalin.bacur@....com,
        netdev@...r.kernel.org
Cc:     oss@...error.net, chzigotzky@...osoft.de,
        linuxppc-dev@...ts.ozlabs.org
Subject: Re: [RFC PATCH dpss_eth] Don't initialise ports with no PHY



On 4/24/2020 3:29 PM, Darren Stevens wrote:
> Since cbb961ca271e ("Use random MAC address when none is given")
> Varisys Cyrus P5020 boards have been listing 5 ethernet ports instead of
> the 2 the board has.This is because we were preventing the adding of the
> unused ports by not suppling them a MAC address, which this patch now
> supplies.
> 
> Prevent them from appearing in the net devices list by checking for a
> 'status="disabled"' entry during probe and skipping the port if we find
> it. 
> 
> Signed-off-by: Darren Stevens <Darren@...vens-zone.net>
> 
> ---
> 
>  drivers/net/ethernet/freescale/fman/mac.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/drivers/net/ethernet/freescale/fman/mac.c b/drivers/net/ethernet/freescale/fman/mac.c
> index 43427c5..c9ed411 100644
> --- a/drivers/net/ethernet/freescale/fman/mac.c
> +++ b/drivers/net/ethernet/freescale/fman/mac.c
> @@ -606,6 +606,7 @@ static int mac_probe(struct platform_device *_of_dev)
>  	struct resource		 res;
>  	struct mac_priv_s	*priv;
>  	const u8		*mac_addr;
> +	const char 		*prop;
>  	u32			 val;
>  	u8			fman_id;
>  	phy_interface_t          phy_if;
> @@ -628,6 +629,16 @@ static int mac_probe(struct platform_device *_of_dev)
>  	mac_dev->priv = priv;
>  	priv->dev = dev;
>  
> +	/* check for disabled devices and skip them, as now a missing
> +	 * MAC address will be replaced with a Random one rather than
> +	 * disabling the port
> +	 */
> +	prop = of_get_property(mac_node, "status", NULL);
> +	if (prop && !strncmp(prop, "disabled", 8) {
> +		err = -ENODEV;
> +		goto _return
> +	}

There is a sorter version: of_device_is_available(mac_node) which will
do the same thing.

> +
>  	if (of_device_is_compatible(mac_node, "fsl,fman-dtsec")) {
>  		setup_dtsec(mac_dev);
>  		priv->internal_phy_node = of_parse_phandle(mac_node,
> 

-- 
Florian