netdev - Re: [RFC PATCH dpss_eth] Don't initialise ports with no PHY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200425001021.GB1095011@lunn.ch>
Date:   Sat, 25 Apr 2020 02:10:21 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Darren Stevens <darren@...vens-zone.net>
Cc:     madalin.bacur@....com, netdev@...r.kernel.org, oss@...error.net,
        chzigotzky@...osoft.de, linuxppc-dev@...ts.ozlabs.org
Subject: Re: [RFC PATCH dpss_eth] Don't initialise ports with no PHY

On Fri, Apr 24, 2020 at 11:29:38PM +0100, Darren Stevens wrote:
> Since cbb961ca271e ("Use random MAC address when none is given")
> Varisys Cyrus P5020 boards have been listing 5 ethernet ports instead of
> the 2 the board has.This is because we were preventing the adding of the
> unused ports by not suppling them a MAC address, which this patch now
> supplies.
> 
> Prevent them from appearing in the net devices list by checking for a
> 'status="disabled"' entry during probe and skipping the port if we find
> it. 

Hi Darren

I'm surprised the core is probing a device which has status disabled.
Are you sure this is the correct explanation?

    Thanks
	Andrew