netdev - Re: [PATCH net-next v1 2/9] net: phy: Add support for polling cable test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200426220714.GA1212378@lunn.ch>
Date:   Mon, 27 Apr 2020 00:07:14 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Florian Fainelli <f.fainelli@...il.com>
Cc:     David Miller <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Chris Healy <cphealy@...il.com>,
        Michal Kubecek <mkubecek@...e.cz>
Subject: Re: [PATCH net-next v1 2/9] net: phy: Add support for polling cable
 test

> > At least with the Marvell PHY, there is no documented way to tell it
> > to abort a cable test. So knowing the user space has lost interest in
> > the results does not help us.
> 
> The same is true with Broadcom PHYs, but I think we should be guarding
> somehow against the PHY state machine being left in PHY_CABLETEST state
> with no other way to recover than do an ip link set down/up in order to
> recover it. We can try to tackle this as an improvement later on.

I did wonder about setting a big timeout in the core. If after 20
seconds it has not returned any results, we probably need to move to
the error state? But that only works for polling. For interrupt driven
PHYs we don't have any sort of timer, we would need to add more
infrastructure to the core.

If the PHY never completed the cable test, we are probably in the land
of driver bugs, and how do we recover from that?

    Andrew