lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 26 Apr 2020 18:05:05 -0700 (PDT) From: David Miller <davem@...emloft.net> To: irusskikh@...vell.com Cc: kuba@...nel.org, netdev@...r.kernel.org, mstarovoitov@...vell.com, dbogdanov@...vell.com Subject: Re: [EXT] Re: [PATCH net-next 08/17] net: atlantic: A2 driver-firmware interface From: Igor Russkikh <irusskikh@...vell.com> Date: Sun, 26 Apr 2020 11:50:19 +0300 > >> From: Jakub Kicinski <kuba@...nel.org> >> Date: Fri, 24 Apr 2020 17:44:47 -0700 >> >>> On Fri, 24 Apr 2020 10:27:20 +0300 Igor Russkikh wrote: >>>> +/* Start of HW byte packed interface declaration */ >>>> +#pragma pack(push, 1) >>> >>> Does any structure here actually require packing? >> >> Yes, please use the packed attribute as an absolute _last_ resort. > > These are HW bit-mapped layout API, without packing compiler may screw up > alignments in some of these structures. The compiler will not do that if you used fixed sized types properly. Please remove __packed unless you can prove it matters.
Powered by blists - more mailing lists