netdev - Re: [PATCH] net: tc35815: Fix phydev supported/advertising mask

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 27 Apr 2020 11:52:31 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     tony.felice@...esys.com
Cc:     akshay.bhat@...esys.com, hkallweit1@...il.com,
        srinivas.kandagatla@...aro.org, natechancellor@...il.com,
        robh@...nel.org, suzuki.poulose@....com, mst@...hat.com,
        andrew@...n.ch, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: tc35815: Fix phydev supported/advertising mask

From: Anthony Felice <tony.felice@...esys.com>
Date: Sun, 26 Apr 2020 22:00:59 -0400

> Commit 3c1bcc8614db ("net: ethernet: Convert phydev advertize and
> supported from u32 to link mode") updated ethernet drivers to use a
> linkmode bitmap. It mistakenly dropped a bitwise negation in the
> tc35815 ethernet driver on a bitmask to set the supported/advertising
> flags.
> 
> Found by Anthony via code inspection, not tested as I do not have the
> required hardware.
> 
> Fixes: 3c1bcc8614db ("net: ethernet: Convert phydev advertize and supported from u32 to link mode")
> Signed-off-by: Anthony Felice <tony.felice@...esys.com>
> Reviewed-by: Akshay Bhat <akshay.bhat@...esys.com>

Applied.