lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 27 Apr 2020 14:37:43 +0200 From: Andrew Lunn <andrew@...n.ch> To: Anthony Felice <tony.felice@...esys.com> Cc: Akshay Bhat <akshay.bhat@...esys.com>, "David S. Miller" <davem@...emloft.net>, Heiner Kallweit <hkallweit1@...il.com>, Srinivas Kandagatla <srinivas.kandagatla@...aro.org>, Nathan Chancellor <natechancellor@...il.com>, Rob Herring <robh@...nel.org>, Suzuki K Poulose <suzuki.poulose@....com>, "Michael S. Tsirkin" <mst@...hat.com>, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] net: tc35815: Fix phydev supported/advertising mask On Sun, Apr 26, 2020 at 10:00:59PM -0400, Anthony Felice wrote: > Commit 3c1bcc8614db ("net: ethernet: Convert phydev advertize and > supported from u32 to link mode") updated ethernet drivers to use a > linkmode bitmap. It mistakenly dropped a bitwise negation in the > tc35815 ethernet driver on a bitmask to set the supported/advertising > flags. > > Found by Anthony via code inspection, not tested as I do not have the > required hardware. > > Fixes: 3c1bcc8614db ("net: ethernet: Convert phydev advertize and supported from u32 to link mode") > Signed-off-by: Anthony Felice <tony.felice@...esys.com> > Reviewed-by: Akshay Bhat <akshay.bhat@...esys.com> Reviewed-by: Andrew Lunn <andrew@...n.ch> Thanks. Andrew
Powered by blists - more mailing lists