netdev - Re: [PATCH V2 net-next 09/13] net: ena: implement ena_com_get_admin_polling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200428120443.09c4931f@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Tue, 28 Apr 2020 12:04:43 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     <sameehj@...zon.com>
Cc:     <davem@...emloft.net>, <netdev@...r.kernel.org>,
        Arthur Kiyanovski <akiyano@...zon.com>, <dwmw@...zon.com>,
        <zorik@...zon.com>, <matua@...zon.com>, <saeedb@...zon.com>,
        <msw@...zon.com>, <aliguori@...zon.com>, <nafea@...zon.com>,
        <gtzalik@...zon.com>, <netanel@...zon.com>, <alisaidi@...zon.com>,
        <benh@...zon.com>, <ndagan@...zon.com>,
        Igor Chauskin <igorch@...zon.com>
Subject: Re: [PATCH V2 net-next 09/13] net: ena: implement
 ena_com_get_admin_polling_mode()

On Tue, 28 Apr 2020 07:27:22 +0000 sameehj@...zon.com wrote:
> From: Arthur Kiyanovski <akiyano@...zon.com>
> 
> Before this commit there was a function prototype named
> ena_com_get_ena_admin_polling_mode() that was never implemented.
> 
> This commit:
> 1. Changes the name of the function by removing the redundant double "ena_" in it.
> 2. Adds an implementation to the function.
> 3. Fixes a typo in the description of the function.
> 
> Signed-off-by: Igor Chauskin <igorch@...zon.com>
> Signed-off-by: Arthur Kiyanovski <akiyano@...zon.com>

Doesn't look like this function is called upstream, though.

You should just remove it.