netdev - Re: [PATCH V2 net-next 11/13] net: ena: move llq configuration from ena_probe to ena_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200428124621.0ce3dc5c@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Tue, 28 Apr 2020 12:46:21 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     <sameehj@...zon.com>
Cc:     <davem@...emloft.net>, <netdev@...r.kernel.org>,
        Arthur Kiyanovski <akiyano@...zon.com>, <dwmw@...zon.com>,
        <zorik@...zon.com>, <matua@...zon.com>, <saeedb@...zon.com>,
        <msw@...zon.com>, <aliguori@...zon.com>, <nafea@...zon.com>,
        <gtzalik@...zon.com>, <netanel@...zon.com>, <alisaidi@...zon.com>,
        <benh@...zon.com>, <ndagan@...zon.com>
Subject: Re: [PATCH V2 net-next 11/13] net: ena: move llq configuration from
 ena_probe to ena_device_init()

On Tue, 28 Apr 2020 07:27:24 +0000 sameehj@...zon.com wrote:
> +	ena_dev->mem_bar = devm_ioremap_wc(&pdev->dev,
> +					   pci_resource_start(pdev, ENA_MEM_BAR),
> +					   pci_resource_len(pdev, ENA_MEM_BAR));

Is there anything that'd undo the mapping in case of reset?

The use of devm_ functions outside of probe seems questionable.